[stable35] fix(comments): recreate comment editor on Activity tab remount - #64079
Merged
Conversation
backportbot
Bot
requested review from
joshtrichards,
jospoortvliet,
kristian-zendato,
skjnldsv,
sorbaugh and
szaimen
and removed request for
a team
September 5, 2026 12:18
backportbot
Bot
added
bug
3. to review
susnux
approved these changes
Sep 7, 2026
…ment editor The comment editor Vue app instance was kept in a closure variable and reused across Activity tab mount/unmount cycles. unmount() destroyed the app via app.unmount() but never reset the variable, so the next mount() skipped creating a new app and called mount() on an already- destroyed instance — a silent no-op. This made the comment field disappear after leaving and returning to the Activity tab, only recoverable via a full page reload. Reset `app` to undefined after unmounting so the editor is recreated on the next mount. Fixes #63487 Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Jos Poortvliet <jospoortvliet@gmail.com>
AndyScherzinger
force-pushed
the
backport/63505/stable35
branch
from
September 7, 2026 11:53
0cbd298 to
f5d91dc
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #63505